Skip to content

Fix publish docs workflow #85

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Fix publish docs workflow #85

merged 4 commits into from
Sep 23, 2021

Conversation

iKintosh
Copy link
Contributor

@iKintosh iKintosh commented Sep 22, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? make lint (poetry install -E style).
  • Did you make sure to update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest tests/ ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

  • fix bug in publish-docs workflow

Related Issue

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #85 (4dae40d) into master (efa0aac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files          49       49           
  Lines        2182     2182           
=======================================
  Hits         1970     1970           
  Misses        212      212           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa0aac...4dae40d. Read the comment docs.

Copy link
Contributor

@diadorer diadorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iKintosh iKintosh merged commit ee195e6 into master Sep 23, 2021
@iKintosh iKintosh deleted the fix-publish-docs-workflow branch September 23, 2021 08:03
iKintosh added a commit that referenced this pull request Sep 23, 2021
* set version

* 💣 release 1.1.0

* set version

* update run instructions

fix bug: need to install poetry before using it

(cherry picked from commit ee195e6)
iKintosh added a commit that referenced this pull request Sep 23, 2021
* set version

* 💣 release 1.1.0

* set version

* update run instructions

fix bug: need to install poetry before using it

(cherry picked from commit ee195e6)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants