Skip to content

Add BinsegTrendTransform, ChangePointsTrendTransform #87

Merged
merged 10 commits into from
Sep 24, 2021
Merged

Conversation

julia-shenshina
Copy link
Contributor

@julia-shenshina julia-shenshina commented Sep 23, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #69

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #87 (99a99c9) into master (d48e4f5) will increase coverage by 0.58%.
The diff coverage is 99.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   88.04%   88.63%   +0.58%     
==========================================
  Files          50       52       +2     
  Lines        2283     2410     +127     
==========================================
+ Hits         2010     2136     +126     
- Misses        273      274       +1     
Impacted Files Coverage Δ
etna/transforms/binseg.py 96.96% <96.96%> (ø)
etna/transforms/__init__.py 100.00% <100.00%> (ø)
etna/transforms/change_points_trend.py 100.00% <100.00%> (ø)
etna/transforms/detrend.py 98.21% <0.00%> (-0.07%) ⬇️
etna/transforms/datetime_flags.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48e4f5...99a99c9. Read the comment docs.

@julia-shenshina julia-shenshina self-assigned this Sep 23, 2021
martins0n
martins0n previously approved these changes Sep 24, 2021
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥
Tests are awesome!

etna/transforms/change_points_trend.py Outdated Show resolved Hide resolved
etna/transforms/change_points_trend.py Outdated Show resolved Hide resolved
martins0n
martins0n previously approved these changes Sep 24, 2021
@martins0n martins0n merged commit 014e6b6 into master Sep 24, 2021
@martins0n martins0n deleted the ETNA-793 branch September 24, 2021 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinsegTrendTransform
3 participants