Skip to content

ETNA-794 Add minimal examples to all TSDatasets methods #67 #92

Merged
merged 8 commits into from
Sep 28, 2021

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Sep 23, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Tested examples with doctest in important public methods.

Related Issue

Closing issues

closes #67

@martins0n martins0n self-assigned this Sep 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #92 (f0fb253) into master (fecc27f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files          54       54           
  Lines        2466     2466           
=======================================
  Hits         2163     2163           
  Misses        303      303           
Impacted Files Coverage Δ
etna/analysis/plotters.py 13.97% <ø> (ø)
etna/loggers/__init__.py 100.00% <ø> (ø)
etna/datasets/tsdataset.py 86.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecc27f...f0fb253. Read the comment docs.

@martins0n martins0n marked this pull request as ready for review September 23, 2021 23:33
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@julia-shenshina julia-shenshina merged commit 51afbc2 into master Sep 28, 2021
@iKintosh iKintosh deleted the ETNA-794 branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minimal examples to all TSDatasets methods
4 participants