Skip to content

Fix SARIMAXModel to work with exogenous data on pmdarima>=2.0 #940

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 14, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #939.

Closing issues

Closes #939.

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Sep 14, 2022
@Mr-Geekman Mr-Geekman self-assigned this Sep 14, 2022
@github-actions
Copy link

github-actions bot commented Sep 14, 2022

🚀 Deployed on https://deploy-preview-940--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 14, 2022 12:55 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #940 (1a7ce15) into master (cb19d87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   84.99%   85.00%           
=======================================
  Files         133      133           
  Lines        7611     7614    +3     
=======================================
+ Hits         6469     6472    +3     
  Misses       1142     1142           
Impacted Files Coverage Δ
etna/models/sarimax.py 94.77% <ø> (ø)
etna/libs/pmdarima_utils/arima.py 100.00% <100.00%> (ø)
etna/models/autoarima.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit a02d2d6 into master Sep 15, 2022
@martins0n martins0n deleted the issue-939 branch September 15, 2022 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SARIMAXModel isn't working with exogenous data on pmdarima>=2.0
3 participants