Fix line-height issues (font) #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtlynch
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 24 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some testing in Chrome I had noticed that the line-heights of the font render differently. This leads to visual misalignment of the text position in the status- and menu-bar. This is an issue with the font files themselves and it had already been reported and fixed in the official Overpass font repo. However, Google apparently still seems to distribute an older version. Therefore I pulled in the most recent font-files from the official repo in this PR.
It’s hard to spot, but once you know you cannot unsee it: in Chrome the vertical alignment of the text is slightly off towards the bottom, whereas the connection dot slightly gravitates towards the top.)
Before (Chrome left, Firefox right)
After (Chrome left, Firefox right)
This change is