sd: Preventing panic when CGo calls in interrupt escape arguments to heap #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HattoriHanzo031
force-pushed
the
noescape-cgo-wrappers
branch
from
aa40fa4
to
89c1806
Compare
aykevl
approved these changes
Sep 1, 2023
aykevl
added a commit
that referenced
this pull request
Dec 24, 2023
This seems to have been broken since #192, I suspect it's a problem with the struct calling convention (which most certainly is a TinyGo CGo bug, but at least this works around the problem).
|
Unfortunately this seems to have caused an issue for me, see: #209 |
deadprogram
pushed a commit
that referenced
this pull request
Dec 25, 2023
This seems to have been broken since #192, I suspect it's a problem with the struct calling convention (which most certainly is a TinyGo CGo bug, but at least this works around the problem).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets issue #176
Some SD Cgo calls are unnecessarily causing variables to escape to heap, and if called from an interrupt are causing panics.
Local CGo wrappers are added to prevent this.
This is a workaround until there is a proper way to prevent CGo calls escaping variables to heap (for example this Go proposal: golang#56378 )