avr: fix target triple #1203
Merged
avr: fix target triple #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was `avr-atmel-none`, which is incorrect. It must be `avr-unknown-unknown`. Additionally, there is no reason to specify the target triple per chip, it can be done for all AVR chips at once as it doesn't vary like Cortex-M chips.
|
Tested using Arduino Uno and DIgispark, worked as expected. Now merging, thanks for this great research @aykevl and kudos to the Rust community for all their related LLVM work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was
avr-atmel-none, which is incorrect. It must beavr-unknown-unknown.Additionally, there is no reason to specify the target triple per chip, it can be done for all AVR chips at once as it doesn't vary like Cortex-M chips.
Comment that triggered this PR: rust-lang/rust#44052 (comment)