Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Bugfix/fix compilation error on ios for 8.0.0.beta9 #628

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Bugfix/fix compilation error on ios for 8.0.0.beta9 #628

merged 2 commits into from
Mar 30, 2020

Conversation

nobodyabcd
Copy link
Contributor

@nobodyabcd nobodyabcd commented Mar 27, 2020

Proposed changes

@cybergrind, please have a look at this PR. this is a fix to issue Issue 585

Currently, user on Xcode could not build tipsi-stripe version 8.0.0.beta9 because a typo here:

case STPPaymentMethodTypeFPX: return @"fpx";

fpx is not currently supported, it should be marked as type unknown rather than fpx.

Types of changes

What types of changes does your code introduce to tipsi-stripe?
Put an x in the boxes that apply

  • Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! Next steps are a reminder of what we are going to look at before merging your code.

  • I have added tests that prove my fix is useful or that my feature works
  • I have added necessary documentation (if appropriate)
  • I know that my PR will be merged only if it has tests and they pass

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered.

@cybergrind
Copy link
Member

hey, @fbartho ! Could you please look into recent PR's from @guanhuay and if they are ok, probably we need to release new beta

@fbartho fbartho merged commit 529f7d4 into tipsi:experimental Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants