Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implented integration to Google Closure compiler for better js code minification #202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rilmay
Copy link

@rilmay rilmay commented Nov 14, 2021

I noticed that the current js code minifier is simple whitespace/newline stripper. Google's compiler is a proven and configurable minification tool that can significantly reduce the amount of code, and I thought it would be a good idea to use it in a project. In PR, I have not set this minifier as a standard one, but it will be cool that users will be able to set it in the configuration.

@tipsy
Copy link
Owner

tipsy commented Nov 14, 2021

I think the core of j2html should be dependency free, so I would provide the option to configure your own minifier (through an interface), and provide this as a separate artifact instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants