Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import 플러그인이 Typescript의 module alias를 인식할 수 있도록 처리 #146

Merged
merged 4 commits into from
Oct 29, 2021

Conversation

giwan-dev
Copy link
Contributor

@giwan-dev giwan-dev commented Oct 28, 2021

import 플러그인이 typescript의 module alias를 인식할 수 있도록 처리하는 eslint-import-resolver-typescript 패키지를 설치합니다.

@giwan-dev
Copy link
Contributor Author

release-canary

@giwan-dev giwan-dev added this to the v3.0.0-rc.1 milestone Oct 28, 2021
@github-actions
Copy link
Contributor

v0.0.0-220126c has been published!

@giwan-dev giwan-dev marked this pull request as ready for review October 28, 2021 06:16
@giwan-dev giwan-dev requested a review from a team as a code owner October 28, 2021 06:16
polysiya
polysiya previously approved these changes Oct 28, 2021
@polysiya polysiya requested a review from a team October 28, 2021 06:32
@giwan-dev
Copy link
Contributor Author

release-canary

@github-actions
Copy link
Contributor

v0.0.0-17043e0 has been published!

inbeom
inbeom previously approved these changes Oct 29, 2021
Copy link
Contributor

@inbeom inbeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 readme 충돌..!

eslint import 플러그인이 typescript의 모듈 alias를 인식할 수 있게 해주는 플러그인을 설치합니다.
eslint-import-resolver-typescript의 설정을 추가합니다.
createConfig 함수가 tsconfig.json 파일의 경로를 project라는 이름의 파라미터로 받아서
import/resolver의 설정에 추가합니다.

project가 없으면 해당 설정을 추가하지 않습니다.

project 존재 여부와 상관없이 무조건 적용할 수 있는 설정은 index.js에 추가합니다.
project를 넣어주는 것은 typescript일 때만 유효하므로 ts, tsx 파일에만 적용해야합니다.
Copy link
Contributor

@inbeom inbeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@giwan-dev giwan-dev merged commit a85fcb5 into main Oct 29, 2021
@giwan-dev giwan-dev deleted the feature/ts-module-alias branch October 29, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants