Chromedriver now checks Selenium::WebDriver::Chrome#path. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapoorlakshya
force-pushed
the
38_support_chromium
branch
from
195a69f
to
b8185e4
Compare
titusfortner
requested changes
Mar 25, 2019
beauraF
reviewed
Mar 25, 2019
lib/webdrivers/chromedriver.rb
Outdated
| `google-chrome --version` | ||
| if browser_defined? | ||
| Webdrivers.logger.debug "Browser executable: '#{browser_exe}'" | ||
| return `#{browser_exe} --product-version`.strip if browser_defined? |
There was a problem hiding this comment.
Suggested change
| return `#{browser_exe} --product-version`.strip if browser_defined? | |
| return `#{browser_exe} --product-version`.strip |
… Chrome, and get full chromedriver version instead of just the major.
kapoorlakshya
force-pushed
the
38_support_chromium
branch
from
b8185e4
to
928e699
Compare
titusfortner
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selenium::WebDriver::Chrome#pathbefore defaulting to Google Chrome. Addresses [3.7.0] Doesn't work with chromium on Linux #38.chromedriverv2.46 if Chrome/Chromium version is less than 70.LATEST_FILE_*only available for versions > 70.Chromedriver#current_versionnow returns full version -73.0.3683.68instead of73.0.