Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing lint errors in TypeScript #1208

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Fixing lint errors in TypeScript #1208

merged 4 commits into from
Mar 23, 2020

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Mar 5, 2020 •
edited
Loading

Pull Request

Problem

With lint now set up for TypeScript, there are lots of lint errors!

Solution

  • fix lots of lint errors for style issues
  • add return types to match standard rules
  • disable some tests where the code is deliberate

Down to zero errors, but planning to leave until after 5.0.

@shadowspawn shadowspawn changed the title WIP: Fixing lint errors in TypeScript Fixing lint errors in TypeScript Mar 16, 2020
@shadowspawn shadowspawn marked this pull request as ready for review March 16, 2020 09:56
abetomo
abetomo approved these changes Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shadowspawn shadowspawn merged commit e960c90 into tj:develop Mar 23, 2020
@shadowspawn shadowspawn deleted the feature/lint-ts branch March 23, 2020 04:47
@shadowspawn shadowspawn added pending release Merged into a branch for a future release, but not released yet and removed pending release Merged into a branch for a future release, but not released yet labels Apr 25, 2020
This was referenced Apr 27, 2020
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @abetomo