-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up state from previous parse call when calling parse()
/ parseAsync()
#1919
Commits on Jul 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3c6ef71 - Browse repository at this point
Copy the full SHA 3c6ef71View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6d53b2 - Browse repository at this point
Copy the full SHA b6d53b2View commit details -
Improve logic for option values supplied in user code
Public setOptionValueWithSource() method only accepts 'config' as source
Configuration menu - View commit details
-
Copy full SHA for 437291f - Browse repository at this point
Copy the full SHA 437291fView commit details -
Remove public method functionality overlap
Remove overlap between setOptionValue() and setOptionValueWithSource(). Make the latter's source parameter required.
Configuration menu - View commit details
-
Copy full SHA for fbe911f - Browse repository at this point
Copy the full SHA fbe911fView commit details
Commits on Jul 29, 2023
-
Co-authored-by: John Gee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ebf672a - Browse repository at this point
Copy the full SHA ebf672aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fd0b22 - Browse repository at this point
Copy the full SHA 7fd0b22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 940b111 - Browse repository at this point
Copy the full SHA 940b111View commit details -
Use string instead of OptionValueSource
OptionValueSource is only meaningful as defined in commander-js/extra-typings#3
Configuration menu - View commit details
-
Copy full SHA for 52d5885 - Browse repository at this point
Copy the full SHA 52d5885View commit details -
Make user-supplied option values non-persistent while parsing
Configuration menu - View commit details
-
Copy full SHA for 94e439d - Browse repository at this point
Copy the full SHA 94e439dView commit details -
Add non-persistent user-supplied option support for subcommands
...by adding missing parameter in the _parseCommand() call in _dispatchSubcommand().
Configuration menu - View commit details
-
Copy full SHA for 274be1a - Browse repository at this point
Copy the full SHA 274be1aView commit details
Commits on Jul 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 56eed63 - Browse repository at this point
Copy the full SHA 56eed63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a7bc41 - Browse repository at this point
Copy the full SHA 4a7bc41View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcc97e2 - Browse repository at this point
Copy the full SHA fcc97e2View commit details -
Return proxy redirecting keys for options-as-properties from Command …
…constructor Required for options-as-properties support in resetParseState(). Has the added benefit of supporting (in a limited way) option names conflicting with instance's properties even when options-as-properties are enabled.
Configuration menu - View commit details
-
Copy full SHA for 36fa763 - Browse repository at this point
Copy the full SHA 36fa763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 829655d - Browse repository at this point
Copy the full SHA 829655dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 633e4e4 - Browse repository at this point
Copy the full SHA 633e4e4View commit details -
Fully support options with names conflicting with instance properties
Additionally fix comment impreciseness
Configuration menu - View commit details
-
Copy full SHA for be00f59 - Browse repository at this point
Copy the full SHA be00f59View commit details
Commits on Aug 3, 2023
-
Return proxy from constructor further up the prototype chain
Borrowed from eb142d8 that was supposed to land in the now-closed tj#1921. The change ensures the this object used in Command is the proxy from the very beginning, even in the constructor. This solves pretty much all issues with returning the proxy from a constructor. For example, private fields can be used now. More details available at: tj#1921 (comment) Additionally, the ownKeys() trap and wrong spelling in comments have been fixed (the former change being borrowed from fc927c8).
Configuration menu - View commit details
-
Copy full SHA for b53703b - Browse repository at this point
Copy the full SHA b53703bView commit details