Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dynamically updating version number and version option flags and description #1933

Closed
wants to merge 4 commits into from
Closed

Allow dynamically updating version number and version option flags and description #1933

wants to merge 4 commits into from

Commits on Aug 3, 2023

  1. Fix version() parameter type 

    Borrowed from a3f0e28 that was supposed to land in the now-closed tj#1921.
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e8bea4a View commit details
    Browse the repository at this point in the history

  2. Initialize _version, _versionOptionName in constructor 

    The _version and _versionOptionName properties are initialized to
undefined in the constructor. The reasoning is
- to make them visible when the Command instance is logged into the
console before .version() is called, and not only appear after suddenly
- to not break anything if the proxy use for consistent option value
handling in the legacy setOptionValueWithSource mode suggested in tj#1919
(and previously in tj#1921) is adopted
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b488e6e View commit details
    Browse the repository at this point in the history

  3. Store version option instance instead of just name 

    Storing the Option instance of the version option instead of just its
.attributeName() (_versionOptionName) is meaningful for cases when other
properties of the instance need to be accessed (not currently the case,
but could be in the future).
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3c94dfd View commit details
    Browse the repository at this point in the history

  4. Allow version number and option's flags and description updates

    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    2f3c4c3 View commit details
    Browse the repository at this point in the history