Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public Arguments property #2010

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Sep 10, 2023

Pull Request

Problem

There is no public property for the command Argument[], like there is with program.options and program.commands.

The Help.visibleArguments() is not a working alternative since unless the argument have descriptions, there are no visible arguments.

See: #1823

Solution

Add .registeredArguments, as suggested in #1970

Reminder to self: preserve co-author commit comment.

ChangeLog

  • add cmd.registeredArguments to access the command Argument array

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shadowspawn shadowspawn merged commit 7d23437 into tj:develop Sep 11, 2023
11 checks passed
@shadowspawn shadowspawn deleted the feature/public-arguments-property branch September 11, 2023 07:23
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Sep 11, 2023
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Oct 13, 2023
@shadowspawn
Copy link
Collaborator Author

Shipped in Commander v11.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants