Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Supported template engines" in README.md #322

Merged
merged 6 commits into from
Jul 30, 2019
Merged

Conversation

A-312
Copy link
Contributor

@A-312 A-312 commented Jun 26, 2019

I made this table for my npm package. (I think it can interest you)

@doowb
Copy link
Collaborator

doowb commented Jun 27, 2019

This looks great. I just merged in another PR that caused this to be conflicted. Will you update the table with the new update?

@A-312
Copy link
Contributor Author

A-312 commented Jun 27, 2019

I'll do, ping me when I can

@A-312
Copy link
Contributor Author

A-312 commented Jul 19, 2019

@doowb Hi, this PR is ready , are you waiting for something ?

@doowb
Copy link
Collaborator

doowb commented Jul 19, 2019

are you waiting for something

No, thanks for the ping, I've just been busy. I'll take a look this weekend.

@A-312
Copy link
Contributor Author

A-312 commented Jul 30, 2019

@doowb You forgot it 😜

@doowb
Copy link
Collaborator

doowb commented Jul 30, 2019

Thanks for the reminder... again ;)

@doowb doowb merged commit 3860d07 into tj:master Jul 30, 2019
@nebrelbug
Copy link
Contributor

Hey @doowb and @A-312, it looks like when you created the new table you left out Squirrelly, which had just gotten added in #317.

Should I make a pull request to add it?
Thanks!

@doowb
Copy link
Collaborator

doowb commented Sep 9, 2019

Should I make a pull request to add it?

Yes please! Sorry for overlooking it when merging.

@A-312
Copy link
Contributor Author

A-312 commented Sep 9, 2019

@nebrelbug Sorry ! I make a mistake in my rebase :(

@nebrelbug
Copy link
Contributor

@A-312 @doowb just created the pull request! See #326 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants