unescape fallback for malformed uri components #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of just ignoring wrong encoded uri components, we should at leas t unescape them with the default javascript unescape function, which doe sn't break on malformed encodings.
|
mind adding a test before I merge? |
|
sure :). i also added a case to test if iso-8859-1 data is unescaped correctly. i am not sure if this is an issue we should care about though. if it doesn't belong there, leave it out. |
|
@denisu wanna rebase by any chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of just ignoring wrong encoded uri components, we should at least unescape them with the default javascript unescape function, which doesn't break on malformed encodings.
this fixes issues in a messed up iso-8859-1 environment.