Skip to content

Commit

Permalink
feat(metrics): start module run durations buckets at 0.25s instead of 1s
Browse files Browse the repository at this point in the history
This should better capture scripts that execute extremely quickly. From
testing and sampling, small scripts are often running on the order of
nanoseconds for noop type scripts and microseconds for very simple
things, for reference.
  • Loading branch information
tjhop committed Aug 10, 2024
1 parent d7bc17f commit 490cc41
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/manager/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ var (
prometheus.HistogramOpts{
Name: "mango_manager_module_run_duration_seconds",
Help: "Histogram of durations of how long it took a given module to run, in seconds",
Buckets: prometheus.ExponentialBuckets(1, 2, 8),
Buckets: prometheus.ExponentialBuckets(0.25, 2, 10),
},
[]string{"module", "script"},
)
Expand Down

0 comments on commit 490cc41

Please sign in to comment.