Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding custom games using installers #106

Closed
neuromancer opened this issue Oct 24, 2018 · 10 comments
Closed

Support adding custom games using installers #106

neuromancer opened this issue Oct 24, 2018 · 10 comments

Comments

@neuromancer
Copy link
Contributor

Adding some custom games using compatibility options requires to run some executable (e.g. Origin or UPlay installer). This is not properly supported by the 'custom game' options, since it will only force you select the installer as the game executable.

@tkashkin
Copy link
Owner

Are Origin/Uplay games even working in Wine?

It should be possible to add Origin/Uplay itself as a game and install/launch games in prefix.

@neuromancer
Copy link
Contributor Author

Are Origin/Uplay games even working in Wine?

Yes, most of them. Origin works fine in Wine-stagging and Valve is fixing a lot issues in Proton to run UPlay since it are required for some games (e.g. ValveSoftware/Proton#1735).

It should be possible to add Origin/Uplay itself as a game and install/launch games in prefix.

You can install them, but the installers are used as 'executable'. If you try to change the executable to use Origin.exe or UPlay.exe, it fails (#105)

@neuromancer
Copy link
Contributor Author

After fixing #105, it works:

uplay-origin

One side effect of using a custom game with a compatibility tool won't set the proper icon (as you can see in the screenshot).

@tkashkin
Copy link
Owner

Now you can try to use "custom emulators" for this. #103 (comment)

@neuromancer
Copy link
Contributor Author

I'm not sure how to use "custom emulators" for that, since UPlay and Origin have undocumented launch options... Anyway, changing the path (and directory) works well to manually add UPlay/Origin games since #105 was fixed.

@tkashkin
Copy link
Owner

tkashkin commented Oct 31, 2018

I was thinking about how to implement it and will try to do that soon.
But yes, I guess "custom emulators" feature is not suitable for that case.

@tkashkin tkashkin reopened this Oct 31, 2018
tkashkin added a commit that referenced this issue Nov 1, 2018
Support adding custom games using installers (#106)
Implement custom emulators removal
@tkashkin
Copy link
Owner

tkashkin commented Nov 1, 2018

Implemented in 7e443e4 and seems to work correctly. Not implemented yet for custom emulators.
Should work the same way as regular game installers and support all already supported installer types. Archives are also supported.

@neuromancer
Copy link
Contributor Author

It works fine!. I tested with a few installer: sometimes the popup to select the binary is triggered too soon. I suspect that certain installers run a program in the background and the control flow returns to GameHub to open the binary selection popup. If you don't care about that, just close this issue.

@tkashkin
Copy link
Owner

tkashkin commented Nov 3, 2018

Custom emulators now can also be added with installers. It may be a bit buggy and UI may be a bit confusing.

tkashkin added a commit that referenced this issue Nov 3, 2018
@tkashkin
Copy link
Owner

tkashkin commented Nov 3, 2018

f4a4847 fixes some bugs for this issue.

It also improves Wine/Proton support:

  • Game directory is now mounted in Wine environment as D: drive
  • There's button to kill everything in prefix
  • Bugfixes

Also it's possible to use Uplay as "custom emulator":

  • Install Uplay and setup it:
    image
  • Run it, install games somewhere
  • Setup games (find game shortcut in Uplay prefix and open it in text editor to get launch URL):
    image

@tkashkin tkashkin closed this as completed Nov 7, 2018
@Lucki Lucki mentioned this issue Apr 1, 2019
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Support adding custom games using installers (tkashkin#106)
Implement custom emulators removal


Former-commit-id: 7e443e4
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Bugfixes for tkashkin#106


Former-commit-id: f4a4847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants