Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaped names allow colon (:) #70

Closed
neuromancer opened this issue Sep 15, 2018 · 2 comments
Closed

Escaped names allow colon (:) #70

neuromancer opened this issue Sep 15, 2018 · 2 comments

Comments

@neuromancer
Copy link
Contributor

Some Windows installer will refuse to install to a directory with a colon in it's name (e.g. "Blood 2: The Blood Group"). Remove it from escaped_name to avoid this issue:

GameHub/src/data/Game.vala

Lines 222 to 228 in 04e2799

public virtual string escaped_name
{
owned get
{
return Utils.strip_name(name.replace(" ", "_"), "_'.,");
}
}

@neuromancer neuromancer changed the title Escaped names allows colon (:) Escaped names allow colon (:) Sep 15, 2018
@tkashkin
Copy link
Owner

Utils.strip_name should strip chars, including :.
However I've found a bug. continue should be here instead of break:

https://github.com/tkashkin/GameHub/blob/master/src/utils/Utils.vala#L222

Fixed for next commit.

tkashkin added a commit that referenced this issue Sep 16, 2018
@tkashkin
GamesView postponed updates (#67)
5e03bce 
"Installed" tag (#69)
Fix Utils.strip_name (#70)
Partly update localizations
@tkashkin
Copy link
Owner

Test with latest commit.

Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
@tkashkin
GamesView postponed updates (tkashkin#67)
197840f 
"Installed" tag (tkashkin#69)
Fix Utils.strip_name (tkashkin#70)
Partly update localizations


Former-commit-id: 5e03bce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neuromancer @tkashkin