add sessions to wallet stamper demo #338
Conversation
andrewkmin
force-pushed
the
andrew/wallet-stamper-sessions
branch
from
d0e4c70
to
8008627
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
changed the title
|
|
||
| // Need to save resulting bundle and information. | ||
| // This is required by the authIframeClient abstraction. | ||
| localStorage.setItem("CREDENTIAL_BUNDLE", result?.credentialBundle!); |
There was a problem hiding this comment.
This is soon to be abstracted away once we have proper support in our higher level SDK packages.
|
|
||
| const handleCreateWallet = (walletName: string) => { | ||
| createWallet(walletName, () => { | ||
| getWallets().then((wallets) => setWallets(wallets)); |
There was a problem hiding this comment.
Passing a callback here. A bit of an antipattern, but just a quick solution until proper resource fetching is in place
| return whoami; | ||
| } | ||
|
|
||
| async function createWallet(walletName: string) { | ||
| async function createWallet(walletName: string, callback: any) { |
There was a problem hiding this comment.
Note: bit of an antipattern. See caller in examples/with-wallet-stamper/src/components/user.tsx
| <body className={inter.className}> | ||
| <Providers>{children}</Providers> | ||
| </body> | ||
| <TurnkeyReactProvider config={turnkeyConfig}> |
There was a problem hiding this comment.
We essentially have two wrappers here: TurnkeyReactProvider from @turnkey/sdk-react, and another one that's created within this project. I included TurnkeyReactProvider in this demo because it abstracts away some iframe-related logic, so if it's confusing as to why where are two separate providers, I hope that offers some clarity.
andrewkmin
force-pushed
the
andrew/wallet-stamper-sessions
branch
from
8008627
to
5766067
Compare
andrewkmin
force-pushed
the
andrew/wallet-stamper-sessions
branch
from
5766067
to
b0e927b
Compare
Summary & Motivation
Add session support to the wallet stamper demo. See recording below:
Screen.Recording.2024-08-21.at.5.06.36.PM.mov
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.