-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Colormap.num_colors
and document usage for cycling through qualitative colormaps
#55
Expose Colormap.num_colors
and document usage for cycling through qualitative colormaps
#55
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 96.85% 96.86%
=======================================
Files 152 152
Lines 1972 1975 +3
=======================================
+ Hits 1910 1913 +3
Misses 62 62 ☔ View full report in Codecov by Sentry. |
Colormap.num_colors
and document usage for cycling through qualitative colormaps Colormap.num_colors
and document usage for cycling through qualitative colormaps
Addressed the PR comments. The codecov patch check failed, but given the code changes here, I don't see a need to add more tests. |
equivalent call to the above is | ||
|
||
```python | ||
c(np.linspace(0, 2, 16, endpoint=False) % 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint=False
🤯 😂 can't believe i hadn't found that
thanks @andy-sweet! |
Closes #54
Here's a quick attempt at the basic additions described in #54. Along with a rough attempt at document usage of qualitative colormaps more generally.
Not quite ready for review, but any feedback about anything is welcome - structure and style included.
As I wrote this, I do feel a stronger need for something like
Colormap(x, cycle=True)
orColormap.cycle(x)
to handle iterable/ndarray inputs, but haven't gone there yet.