Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix build by adding ruff unsafe-fixes and other build fixes #229

Merged
merged 10 commits into from
Nov 12, 2023

Conversation

tlambert03
Copy link
Owner

some of the ruff formatting we want during autogeneration is now opt-in with the --unsafe-fixes flag

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #229 (8fba664) into main (2f7adb2) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   86.38%   86.38%           
=======================================
  Files          26       26           
  Lines        1256     1256           
=======================================
  Hits         1085     1085           
  Misses        171      171           
Files Coverage Δ
src/ome_autogen/main.py 97.72% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codspeed-hq bot commented Nov 11, 2023

CodSpeed Performance Report

Merging #229 will not alter performance

Comparing ruff-up (8fba664) with main (bc5b01d)

Summary

✅ 9 untouched benchmarks

@tlambert03 tlambert03 changed the title fix: fix build by adding ruff unsafe-fixes fix: fix build by adding ruff unsafe-fixes and other build fixes Nov 11, 2023
@tlambert03 tlambert03 merged commit 66ecb9c into main Nov 12, 2023
34 checks passed
@tlambert03 tlambert03 deleted the ruff-up branch November 12, 2023 00:30
@tlambert03 tlambert03 added the bug Something isn't working label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant