Change the way update_localdb() works #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2023
Closed
|
Is there any maintainer to review the PR? |
|
Hi all! This thread has not had any recent activity. |
ghost
approved these changes
Jun 20, 2023
kbdharun
approved these changes
Jun 26, 2023
SethFalco
reviewed
Jun 28, 2023
Co-authored-by: Seth Falco <[email protected]>
…here in previous commit
kbdharun
approved these changes
Jul 11, 2023
SethFalco
approved these changes
Jul 11, 2023
pixelcmtd
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Makes the update of a local database not use
/tmp/tldrXXXXXXtemp directory, but download the update archive to a temporary place inside a tldr home directory (currently~/.tldrc/tmp/), which omits painful cross-FS file manipulation.Why the change?
Makes the local database work on systems where
/tmp/and$HOMEare on different partitions. Resolves #95.How can this be tested?
Remove tldr home folder (
~/.tldrc) and runtldr -uWhere to start code review?
c8424d4
Relevant tickets?
#95
Questions?
C isn't my primary language, so any corrections are welcome.