Fix: prevent freezing of autocomplete in Zsh #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collects all pages using single invocation of base name instead of invoking basename for all individual page
What does it do?
Replaces multiple (now 2400+) invocations of
basename
with the single one.Why the change?
Change prevents freezing of console when user presses
<TAB>
by dramatically decreasing time to lookup page files:Before:
After:
How can this be tested?
Change can be tested by invoking autocompletion in Zsh: enter
tldr
and press tab key.Zsh autocomplete file should be sourced before testing:
source autocomplete/complete.zsh
Where to start code review?
Single line change so it is self-explanatory
Relevant tickets?
None
Questions?
None