Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement short flags and remove --linux, --osx, --sunos #111

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

4G3NT
Copy link
Contributor

@4G3NT 4G3NT commented Nov 25, 2023

Not a complex change. Explicitly define the flags to avoid any problems. The reason why options like -c work is because GNU getopt supports abbreviated arguments.

@4G3NT
Copy link
Contributor Author

4G3NT commented Nov 25, 2023

Man page might need to be updated to reflect the new changes.

@kbdharun kbdharun requested a review from sbrl November 25, 2023 06:06
@4G3NT 4G3NT marked this pull request as draft November 26, 2023 01:28
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! Thanks for the cleanup and assist, @4G3NT!

As @kbdharun suggests though we should update the man page before merging this.

@4G3NT 4G3NT marked this pull request as ready for review November 29, 2023 03:45
@4G3NT 4G3NT changed the title Fix argument phrasing Implement short flags and remove --linux, --osx, --sunos Nov 29, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the fixes. I will test this once locally and merge this PR later today.

@kbdharun kbdharun merged commit c4bcfb0 into tldr-pages:main Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants