Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Add funding information #401

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Conversation

kbdharun
Copy link
Member

@kbdharun kbdharun commented Dec 26, 2022

Signed-off-by: K.B.Dharun Krishna [email protected]

Description

Adding Liberapay to funding information in package.json to show up during npm install and npm fund commands. Ref: https://github.com/npm/rfcs/blob/main/implemented/0017-add-funding-support.md

image

Checklist

Please review this checklist before submitting a pull request.

  • Code compiles correctly
  • Created tests, if possible
  • All tests passing (npm run test:all)
 npm run test:all

> tldr@3.3.8 test:all
> npm run lint && npm test && npm run test:functional


> tldr@3.3.8 lint
> eslint lib test bin/tldr

'eslint' is not recognized as an internal or external command,
operable program or batch file.
  • Extended the README / documentation, if necessary

Adding Liberapay to funding information to show up during npm install and npm fund. Ref: https://github.com/npm/rfcs/blob/main/implemented/0017-add-funding-support.md

Signed-off-by: K.B.Dharun Krishna <[email protected]>
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth getting some other approvals to be sure, but makes sense to me. 👍🏻

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, good thinking.

'eslint' is not recognized as an internal or external command,
operable program or batch file.

I believe you need to run npm install or do npm install -g eslint I think? Not sure. BUt that doesn't matter all that much for this PR I don't think.

@kbdharun
Copy link
Member Author

kbdharun commented Dec 26, 2022

Looks ok to me, good thinking.

'eslint' is not recognized as an internal or external command,
operable program or batch file.

I believe you need to run npm install or do npm install -g eslint I think? Not sure. BUt that doesn't matter all that much for this PR I don't think.

That isn't related I think because npm run test:all would have probably run the tests for all packages in system (I only have 2 packages installed tldr, tldr-lint). Yeah it wouldn't matter much for this PR.

Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@sbrl sbrl merged commit a136e0b into tldr-pages:master Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants