-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change language priority for environment variables #123
Conversation
Does it agree with the specification, though? I think it should be |
Because I'm bad at typing and it should be |
I read TLDR_LANGUAGE in the same role of the --language flag to replace all other languages.
All right, then I will do that.
Ok, thanks. |
I've updated the language handling to fit my proposal in tldr-pages/tldr#4092 (comment) to test it for convenience. |
Since tldr-pages/tldr#4101 was merged I changed this from Draft to PR. |
Should I bump client_specification to 1.3 in this PR, or would this be done in an extra commit? |
@columbarius go ahead, nice catch! |
client_specification bumped. I guess, I should have written this earlier to trigger a notification? |
No need, I am just leaving the final merge decision to @MasterOdin. |
Thanks for this. Still some refactoring I'd like to do in the next week or so before cutting a new release. |
Ok, thanks for merging. |
Regarding the language priority discussed in #122 and tldr-pages/tldr#4101 I have implemented a solution. My suggestion would be a priority like that
, while ! is unset.
I'm also interested, where LANGUAGES originates from. While I couldn't find a notion of it in the archwiki, or at gnu.org, I found the LANGUAGE environment variable instead.
Since this topic is still in discussion I'm submitting this as a draft in case it could be useful.