Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: build and deploy PDF pages for translations #10969

Merged
merged 2 commits into from
Oct 21, 2023
Merged

scripts: build and deploy PDF pages for translations #10969

merged 2 commits into from
Oct 21, 2023

Conversation

kbdharun
Copy link
Member

Superseeds #10846

Fixes

  • Updated the failing deploy script.

@github-actions github-actions bot added documentation Issues/PRs modifying the documentation. tooling Helper tools, scripts and automated processes. labels Oct 13, 2023
@kbdharun
Copy link
Member Author

@acuteenvy If possible, can you check out this PR?

Basically, we have tested and verified building PDFs, but the deploy.sh script seems to fail during execution (see #10846 (comment)). Feel free to fix it in the branch.

@acuteenvy
Copy link
Member

acuteenvy commented Oct 21, 2023 •
edited
Loading

cp: cannot stat '/home/runner/work/tldr/tldr/scripts/pdf/tldr-book*.pdf': No such file or directory

Shell wildcards are not expanded in single/double quotes. The shell doesn't expand *, cp tries to copy tldr-book*.pdf - the file doesn't exist, and so it fails.

acuteenvy
acuteenvy approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@acuteenvy acuteenvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it seems you have fixed it yourself.

sebastiaanspeck
sebastiaanspeck requested changes Oct 21, 2023
View reviewed changes
scripts/pdf/render.py Outdated Show resolved Hide resolved
@kbdharun kbdharun merged commit e35b482 into main Oct 21, 2023
8 checks passed
@kbdharun kbdharun deleted the scripts/l10n-pdf branch October 21, 2023 21:04
@kbdharun
Copy link
Member Author

Now, we wait to see if the deploy succeeds or else I will revert the change like last time.

@kbdharun
Copy link
Member Author

Update: The deploy works and the PDF for translations has been deployed successfully.

Now, we need to document all the PDF files per language maybe as a table in either wiki or in the repo itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuteenvy acuteenvy acuteenvy approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@MasterOdin MasterOdin Awaiting requested review from MasterOdin

Assignees
No one assigned
Labels
documentation Issues/PRs modifying the documentation. tooling Helper tools, scripts and automated processes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbdharun @acuteenvy @sebastiaanspeck