Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

":": add page #12091

Merged
merged 5 commits into from
Feb 20, 2024
Merged

":": add page #12091

merged 5 commits into from
Feb 20, 2024

Conversation

Magrid0
Copy link
Member

@Magrid0 Magrid0 commented Jan 19, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Adding page requested on #12070

closes #12070

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jan 19, 2024
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/common/:.md seems to be a copy of pages/common/true.md (93% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot

This comment was marked as resolved.

@kbdharun kbdharun changed the title ":": Add page ":": add page Jan 20, 2024
pages/common/:.md Outdated Show resolved Hide resolved
pages/common/:.md Outdated Show resolved Hide resolved

> Returns a successful exit status code of 0.
> Use this with the || operator to make a command always exit with 0.
> More information: <https://www.gnu.org/software/coreutils/true>.
Copy link
Member

@tricantivu tricantivu Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe https://manned.org/:.1 or https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#colon?

The implementation of the command true in coreutils is not the same as :

@vitorhcl
Copy link
Member

vitorhcl commented Jan 21, 2024

Windows does not allow colons in a filename, so should we name the file as "colon.md"?

Magrid0 and others added 2 commits January 23, 2024 19:11
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Alejandro Cervera <[email protected]>
@tldr-bot

This comment was marked as off-topic.

@tldr-bot

This comment was marked as off-topic.

@kbdharun
Copy link
Member

kbdharun commented Jan 30, 2024

Windows does not allow colons in a filename, so should we name the file as "colon.md"?

Yeah, that would work the best in most cases, but since this command is GNU-specific UNIX-specific I think we can just leave the symbol as it is.

@tricantivu
Copy link
Member

Windows does not allow colons in a filename, so should we name the file as "colon.md"?

Yeah, that would work the best in most cases, but since this command is GNU-specific I think we can just leave the symbol as it is.

: is not GNU specific, the features added to true are (i.e --help and --version)

@vitorhcl
Copy link
Member

vitorhcl commented Jan 30, 2024

Yeah, that would work the best in most cases, but since this command is GNU-specific I think we can just leave the symbol as it is.

IMHO we should still rename it to collon.md because there are many cases that you can look for documentation for a different platform. For example: virtual machines, SSH, containers, use your main machine instead of a very limited one, remote access... So we should guarantee all pages can be downloaded on any platform.

@sebastiaanspeck
Copy link
Member

Yeah, that would work the best in most cases, but since this command is GNU-specific I think we can just leave the symbol as it is.

IMHO we should still rename it to collon.md because there are many cases that you can look for documentation for a different platform. For example: virtual machines, SSH, containers, use your main machine instead of a very limited one, remote access... So we should guarantee all pages can be downloaded on any platform.

Agreed, but name it colon.md

pages/common/colon.md Outdated Show resolved Hide resolved
@kbdharun kbdharun merged commit 7838ed9 into main Feb 20, 2024
8 checks passed
@kbdharun kbdharun deleted the Magrid0-patch-2 branch February 20, 2024 14:53
@acuteenvy acuteenvy mentioned this pull request Sep 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page request: :
6 participants