Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockdev: add page #13922

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

DarkMatter-999
Copy link

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

Solves #13699

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 1, 2024
@sebastiaanspeck sebastiaanspeck changed the title blockdev: added page for the command blockdev: add page Oct 1, 2024
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first. Please make sure to read the style guide and contributing guide.

I have added a comment that needs to be addressed before the PR is GTG.

Comment on lines 12 to 36
`blockdev --report /dev/sdX`

- Get the size of a device in 512-byte sectors:

`blockdev --getsz /dev/sdX`

- Set read-only:

`blockdev --setro /dev/sdX`

- Set read-write:

`blockdev --setrw /dev/sdX`

- Flush buffers:

`blockdev --flushbufs /dev/sdX`

- Get the physical block size:

`blockdev --getpbsz /dev/sdX`

- Set the read-ahead value to 128 sectors:

`blockdev --setra 128 /dev/sdX`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`blockdev --report /dev/sdX`
- Get the size of a device in 512-byte sectors:
`blockdev --getsz /dev/sdX`
- Set read-only:
`blockdev --setro /dev/sdX`
- Set read-write:
`blockdev --setrw /dev/sdX`
- Flush buffers:
`blockdev --flushbufs /dev/sdX`
- Get the physical block size:
`blockdev --getpbsz /dev/sdX`
- Set the read-ahead value to 128 sectors:
`blockdev --setra 128 /dev/sdX`
`blockdev --report {{/dev/sdX}}`
- Get the size of a device in 512-byte sectors:
`blockdev --getsz {{/dev/sdX}}`
- Set read-only:
`blockdev --setro {{/dev/sdX}}`
- Set read-write:
`blockdev --setrw {{/dev/sdX}}`
- Flush buffers:
`blockdev --flushbufs {{/dev/sdX}}`
- Get the physical block size:
`blockdev --getpbsz {{/dev/sdX}}`
- Set the read-ahead value to 128 sectors:
`blockdev --setra 128 {{/dev/sdX}}`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the device paths need to be absolute or can they be relative?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the paths are required to be absolute.

@DarkMatter-999
Copy link
Author

Thank you very much,

Fixed the formatting ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants