-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete mode - allow to override track components for each lap #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0afb16.
tmalahie
force-pushed
the
feature/complete-track-improvements
branch
from
July 31, 2024 14:27
5e7b826
to
be5fe07
Compare
tmalahie
force-pushed
the
feature/complete-track-improvements
branch
from
August 10, 2024 11:57
7c20d41
to
79f570a
Compare
tmalahie
force-pushed
the
feature/complete-track-improvements
branch
from
August 10, 2024 15:30
a6aa40c
to
c39ec8b
Compare
tmalahie
force-pushed
the
feature/complete-track-improvements
branch
from
August 11, 2024 10:43
9df3186
to
a264a0f
Compare
tmalahie
force-pushed
the
feature/complete-track-improvements
branch
from
August 11, 2024 17:22
8cf353d
to
c3c0a30
Compare
tmalahie
commented
Aug 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements this basically https://cdn.discordapp.com/attachments/1120728182316867736/1226509042034151474/image.png?ex=66a8dc8f&is=66a78b0f&hm=3a3ad6a35a22dec3a4c2eb0f9fd7eb69613b7ade7e3f8160799aba22d6e52c0f&
Plus some other minor improvements & fixes in the track builder
It's quite a huge changes in the code and will require lots of testing to make sure it won't break anything, but overall it's a major feature that was requested by many members and it should extend a lot the capabilities of the track builder :)