Skip to content

Commit

Permalink
apacheGH-41004: [C++][FS][Azure] Don't run TestGetFileInfoGenerator()…
Browse files Browse the repository at this point in the history
… with Valgrind (apache#41163)

### Rationale for this change

`GetFileInfo()` with generator reports false positive memory leak in Azure SDK for C++.

### What changes are included in this PR?

Don't run `TestGetFileInfoGenerator()` with Valgrind.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41004

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
kou authored and rok committed May 8, 2024
1 parent 4805216 commit 3968adc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cpp/src/arrow/filesystem/test_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "arrow/testing/future_util.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/util/async_generator.h"
#include "arrow/util/config.h"
#include "arrow/util/io_util.h"
#include "arrow/util/key_value_metadata.h"
#include "arrow/util/vector.h"
Expand Down Expand Up @@ -752,7 +753,7 @@ void GenericFileSystemTest::TestGetFileInfoSelector(FileSystem* fs) {
}

void GenericFileSystemTest::TestGetFileInfoGenerator(FileSystem* fs) {
#ifdef ADDRESS_SANITIZER
#if defined(ADDRESS_SANITIZER) || defined(ARROW_TEST_MEMCHECK)
if (have_false_positive_memory_leak_with_generator()) {
GTEST_SKIP() << "Filesystem have false positive memory leak with generator";
}
Expand Down
1 change: 1 addition & 0 deletions cpp/src/arrow/util/config.h.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
#cmakedefine ARROW_GCS
#cmakedefine ARROW_HDFS
#cmakedefine ARROW_S3
#cmakedefine ARROW_TEST_MEMCHECK
#cmakedefine ARROW_USE_GLOG
#cmakedefine ARROW_USE_NATIVE_INT128
#cmakedefine ARROW_WITH_BROTLI
Expand Down

0 comments on commit 3968adc

Please sign in to comment.