Skip to content

Commit

Permalink
apacheGH-41169: [CI][Release] Specify --build-config explicitly on Wi…
Browse files Browse the repository at this point in the history
…ndows (apache#41178)

### Rationale for this change

apache#37821 changed to use `add_test()` usage from old style to new style:

apache@1a1d2c8?diff=unified&w=1#diff-1ce47eec54afaee769086e1a720c5ed65bc347cd8fc60a233de67fd895dda329L763-R764

MSVC generators multi-config generators. With old style, all tests are run without specifying `--build-config` explicitly. With new style, we need to specify `--build-config` explicitly.

See also: https://cmake.org/cmake/help/latest/command/add_test.html

### What changes are included in this PR?

Specify `--build-config` explicitly.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41169

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
kou authored and tolleybot committed May 2, 2024
1 parent 37b3c35 commit 421be8c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion dev/release/verify-release-candidate.bat
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ cmake --build . --target INSTALL --config Release || exit /B 1
@rem Needed so python-test.exe works
set PYTHONPATH_ORIGINAL=%PYTHONPATH%
set PYTHONPATH=%CONDA_PREFIX%\Lib;%CONDA_PREFIX%\Lib\site-packages;%CONDA_PREFIX%\DLLs;%CONDA_PREFIX%;%PYTHONPATH%
ctest -j%NUMBER_OF_PROCESSORS% --output-on-failure || exit /B 1
ctest ^
--build-config Release ^
--output-on-failure ^
--parallel %NUMBER_OF_PROCESSORS% || exit /B 1
set PYTHONPATH=%PYTHONPATH_ORIGINAL%
popd

Expand Down

0 comments on commit 421be8c

Please sign in to comment.