-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete rewrite - generic card #19
Conversation
There is still work to be done on translations and for sure there are some bugs. Please test. I've got the card working now for a VW e-Golf integration, so it should be pretty flexible (this will be added as an example later). The Easee template will also be updated and (if you contribute) several other templates may be added to make the configuration easy for people using the card. For now, the card must be installed by using development option. Next release (based on inputs) may be a pre-release/beta. |
@jcsogo ; hmm, that looks like some bad error handling from my side. but it should appear due to some errors in the yaml config. mind sharing the yaml config with me? Remeber to use EDIT: sorry, just saw the last post. Did you use one of the "templates" or manual config? But anyway, you're right - the readme is not updated after I did some changes the last week. Please see below for a complete config like it should be now (will update the readme shortly, please note the details keyword there, I think this is the most important change):
|
@jcsogo ; sorry, you're right. I did some last minute changes recently (allowing for units on name and location, which doesn't make sense really, but I used it for my e-Golf test where I put a value in location instead of location). Should be fixed now if you download the latest file in /tmp |
Good, with the change is back. Can you elaborate a bit more on the 'templates' for the brands? I have been working in adding more missing sensors to the OpenEVSE integration, and now I can provide something more meaningful, although there is still work to be completed for the actions. |
Great! My idea with the templates is just to make it easy for users that are not comfortable with huge YAML-code. So anyone that is happy doing YAML can do whatever they want, but I'm hoping to make some templates for different integrations which just make it simple to apply everything in a click and your done. I'd be happy to make a brand template for OpenEVSE in cooperation with you! See if the contribution guidelines give you anything, and take a look at the template. It is basically a JSON-formatted setup of your YAML-code and then with some special tokens that will be replaced when doing the UI-editor (to make it simple). Long story short: My idea is that advanced user do what they want, while other users can apply a template which (hopefully) take them straight to a complete solution based on the brand templates. |
This is for testing only, not complete. Sensors and services must be verified.
@jcsogo ; take a look at the last commit I did in between here. Added a very early draft for openEVSE based on your yaml. This is how it could look like. I would need to know a bit more on what service calls are available and which data should be sent when calling them. Are you using the official openEVSE-integration? PS! For brand templates, I won't allow mixing car and charger. I see why you want to do it, and I may even do it myself for my setup, but that's why it is customizable - so people can do what they like. But for templates it should be strictly one template per integration, otherwise it will become a huge mess I think. |
I am going to be offline for some days but I will be able to look at it next weekend. Some of the data I was using was a bit nonsensical as I was testing the card I just wanted some sensor for testing purposes. In the meantime I have been contributing code to the integration to add more sensors, and it is providing more interesting data now. I will create a template that makes sense for most of the users. The integration is not the official, though, because it is quite outdated. It is discussed here and I am using this integration Regarding mixing car and charger, your consideration of not doing it in the template makes complete sense. Actually the charger publishes that data as well, so I can use it from it and be completely independent of the car implementation. |
Sounds good @jcsogo! Appreciate your contributions. Wish you a happy new year's celebration! |
}, | ||
|
||
// OVERRIDE CURRENTLIMITS | ||
currentlimits: [0, 6, 10, 16, 20, 25, 32], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not adding 12 and 48 (max that OpenEVSE supports) be a good idea here?
12A would be the limit you'd want on a 15A breaker, while 48A would be ideal for a 50-60A breaker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @firstof9 - openevse is just work-in-progress right now, so perhaps it could be a good idea. Anyway, the way it is now anyone can customize these values to fit their need. I wouldn't agree that 12A would fit 15A breaker though, but I've seen the discussions on the big o' internet ;) if the dropdown menu becomes too big it is unpractical I've seen, but perhaps I could do something about the formatting of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so these are just the defaults and you can override them with config?
12A on a 15A circuit keeps in line with the "80% rule", just an FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fully customizable. But plan is to make "templates" that matches normal setup for most people, to make it easier.
I know about the 80% rule of thumb, but that's what it is too :)
Hi there, I have a couple of myenergi Zappi chargers and I'd love to try this out when it becomes available in HACS. Thanks |
Hi @Ulrar - sounds good! I've been running the card myself, but didn't get much feedback from anyone else, so I didn't stress it. But I guess it is time to push to pre-release in HACS, I'll see if I can do it soon! |
This sounds nice :) |
Here is a first draft for a generic card which should be fully customizable. Check the readme on how to configure the card.
This is a test for now, please let me know your needs and comments. Testing can be done either by manually downloading and install card from here, or by cloning the branch and run as a developer. After some testing, I plan to merge it and release it as a pre-release also for HACS.