Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby: Fix failed tests #75

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

JRuby: Fix failed tests #75

wants to merge 1 commit into from

Conversation

ashie
Copy link
Collaborator

@ashie ashie commented Sep 1, 2021

From #73

Still 3 tests are failed:

  1) HTTP::Parser should optionally reset parser state on no-body responses
     Failure/Error: expect(@complete).to eq(1)

       expected: 1
            got: 0

       (compared using ==)
     # ./spec/parser_spec.rb:198:in `block in <main>'

  2) HTTP::Parser should ignore extra content beyond specified length
     Failure/Error: @parser <<

     HTTP::Parser::Error:
       Connection already closed
     # org/ruby_http_parser/RubyHttpParser.java:379:in `<<'
     # ./spec/parser_spec.rb:301:in `block in <main>'

  3) HTTP::Parser should parse request: line folding in header value
     Failure/Error: expect(@headers).to eq(test['headers'])

       expected: {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"}
            got: {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"}

       (compared using ==)

       Diff:
       @@ -1 +1 @@
       -"Line1" => "abc\tdef ghi\t\tjkl mno \t \tqrs",
       +"Line1" => "abcdefghijklmno qrs",

     # ./spec/parser_spec.rb:394:in `block in <main>'

Signed-off-by: Takuro Ashie [email protected]

@ashie ashie changed the title CI: Add JRuby again JRurby: Fix failed tests Sep 1, 2021
@ashie ashie changed the title JRurby: Fix failed tests JRuby: Fix failed tests Mar 8, 2022
Still 3 tests are failed:

  1) HTTP::Parser should optionally reset parser state on no-body responses
     Failure/Error: expect(@complete).to eq(1)

       expected: 1
            got: 0

       (compared using ==)
     # ./spec/parser_spec.rb:198:in `block in <main>'

  2) HTTP::Parser should ignore extra content beyond specified length
     Failure/Error: @parser <<

     HTTP::Parser::Error:
       Connection already closed
     # org/ruby_http_parser/RubyHttpParser.java:379:in `<<'
     # ./spec/parser_spec.rb:301:in `block in <main>'

  3) HTTP::Parser should parse request: line folding in header value
     Failure/Error: expect(@headers).to eq(test['headers'])

       expected: {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"}
            got: {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"}

       (compared using ==)

       Diff:
       @@ -1 +1 @@
       -"Line1" => "abc\tdef ghi\t\tjkl mno \t \tqrs",
       +"Line1" => "abcdefghijklmno qrs",

     # ./spec/parser_spec.rb:394:in `block in <main>'

Signed-off-by: Takuro Ashie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant