Buggy diagram width/height

[akfish]

Test Setup

Bugs described in this issue are usually hard to notice. I stumped upon them when using style:

// This code is in Less
.box-shadow (@color: #000, @x: 0, @y: 0, @blur: 1px, @spread, @secondary...) {
  -moz-box-shadow: @color @x @y @blur @spread, @secondary;
  -webkit-box-shadow: @color @x @y @blur @spread, @secondary;
  box-shadow: @color @x @y @blur @spread, @secondary;
}

.diagram {
     background-color: white;
     margin: 10px;
     padding: 10px;
     .box-shadow(rgba(0, 0, 0, 0.2), 0, 0, 0, 1px, rgba(0, 0, 0, 0.45), 0, 3px, 10px);
}

All tests are done in Chrome 33

Case 1 - Problem with padding

This happens with robustness diagram.

Code:

@actor "User" :-> @view "Browser"
@view "Browser" :-> @controller "Server"
@controller "Server" :-> @entity "Database"

Result when padding: 10px

The behavior is inconsistent in different cases:

• padding-top = padding-bottom = 10px

• padding-top (= 5px) < padding-bottom (= 10px)
  
• padding-top (= 10px) > padding-bottom (= 5px)
  
• No padding (for reference)
  

Case 2 - Problem with shadows

No padding:

As you can see, sequence diagram and robustness diagram have different behaviors. The former one didn't take account of shadows when calculating width.

Case 3 - Problem with custom styling

Code:

@found "Browser", ->
  @alt {
    "[200]": -> @message "GET href resources", "HTTP Server"
    "[301]": -> @ref "GET the moved page"
    "[404]": -> @ref "show NOT FOUND"
  }
@find(".ref").css(width:256, "padding-bottom":4)
  .find(".tag").css float:"left"
get_the_moved_page.css "background-color":"#80c080"
show_not_found.css "background-color":"#f0b0b0"

No padding:

It looks like that the size is calculated before custom styling is done.

[tmtk75]

Hello, thanks for your report and I'm very very sorry for late reply. I've not realized this ticket so far.

I've seen some of these issues and I'd like to fix them, but unfortunately I don't have a time to improve because I'm busy on my daily biz... It would be thankful for me if you are waiting for fix patiently.

Thanks!

[akfish]

No problem. I can live with those tiny glitches. :)

[togume]

@akfish - this is awesome bug reporting! I'd vote to split them up into their own individual issues so they can be tackled independently/prioritized.

[tmtk75]

JFYI: I think case 2 & case 3 were fixed by 6d6e17c or other commits.