Avoid truncated logs by using spawnSync to inherit stdio streams #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced child_process.exec with child_process.spawnSync. Reason: child_process.exec uses a buffer for stdio and stderr which causes truncated logs if `npm audit` logs thousands of security vulnerabilities. shell: true is necessary to avoid ENOENT in case of npx and npm because these are CMD files with a *.cmd extension.
Execute npm audit fix if auditResult.status!=0 and argv.fix==true.
Update to 1.3.1
Update use-spawnSync to 1.3.1
|
Hi @tnobody , |
|
Hi @curvedriver 👋 |
|
thanks @svettwer ! |
|
@svettwer , thanks for merging! |
|
You're welcome and thx for your contribution! Your changes have been released under version 1.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
execcalls withspawnSyncto ensure that huge logs will not be truncated.child_process.execuses a buffer for stdio and stderr which causes truncated logs ifnpm auditlogs thousands of security vulnerabilities.shell: trueis necessary to avoid ENOENT in case of npx and npm because these are CMD files with a *.cmd extension.