-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MQTT Configuration in a single Backlog command #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not everyone wants to set client, topic and fulltopic and keep the defaults.
IMHO this is to specific for a special use-case.
From my point of view only host, port are common for everyone. There may be setups out there which do not use user and passwort for their MQTT server (even if it is bad).
Since the Backlog functionality is already supported in the current role and the user can already configure the values in one command I do not see a need in making this part of the role.
Perhaps an example in the example section would make sense.
MqttClient {{ tasmota_mqtt_client }}; | ||
MqttTopic {{ tasmota_mqtt_topic }}; | ||
MqttFullTopic {{ tasmota_mqtt_fulltopic }}; | ||
when: > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the list syntax here:
when:
- tasmota_mqtt_user
- tasmota_mqtt_password
- tasmota_mqtt_host
- tasmota_mqtt_port
- tasmota_mqtt_client
- tasmota_mqtt_topic
- tasmota_mqtt_fulltopic
If you don't set values for those fields, they are not set, so I think it's fine to support the full set and only set those fields that are configured. As mqtt is a basic functionality of tasmota, it justifies a build in block imho. |
@deveth0 In my setup I have not set these values and i was not required to. I am only setting |
Nope, cause the default is an empty string which does not cause a change (using commands without value are just read commands for the current value). |
Let's have a chat about this next week. I still see no need for this since it does not offer new functionality. Everything is already possible with the existing implementation and it is simply an new command entry that is passed to the action module. Beside that it will not report a valid changed/not changed response. |
No description provided.