Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry upon first failure (including timeout) in any tasmota update command #32

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

spacelama
Copy link
Contributor

@spacelama spacelama commented Oct 14, 2024

To account for possible device rebooting which can happen at any time after many tasmota update commands, which combines with a deficiency in the HTTPAdapter session handler and results in an update command never timing out, set a timeout and retry manually just the once (per command) after any errors. Multiple reboots are allowed per playbook, but any given command will only be allowed to timeout the once, to prevent endless loops. Fixes #31

…mmand

To account for possible device rebooting which can happen at any time
after many tasmota update commands, which combines with a deficiency
in the HTTPAdapter session handler and results in an update command
never timing out, set a timeout and retry manually just the once (per
command) after any errors.  Multiple reboots are allowed per playbook,
but any given command will only be allowed to timeout the once, to
prevent endless loops.
@tobias-richter
Copy link
Owner

@spacelama thank you for your contribution! I have tested it and can confirm that this is working!

@tobias-richter tobias-richter merged commit f274079 into tobias-richter:master Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't timeout and retry when rebooting the device
2 participants