Uppercase HTTP method and ad user agent string

tobie · Feb 3, 2024 · bd4c8a4 · bd4c8a4
1 parent ca04bd6
commit bd4c8a4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/lib/fetch-url.js b/lib/fetch-url.js
@@ -5,6 +5,10 @@ const request = require("request");
 
 module.exports = (url, service) => {
     return new Promise((resolve, reject) => {
+        if (typeof url == "string") {
+            url = { url };
+        }
+        url.headers = { "User-Agent": "pr-preview" };
         request(url, function (error, response, body) {
             if (error) {
                 error.data = { request_url: url, service: service };

diff --git a/lib/mixins/fetchable.js b/lib/mixins/fetchable.js
@@ -42,7 +42,7 @@ module.exports = (superclass) => class extends superclass {
     getBikeshedUrl(data) {
         let query = this.getQuery(data, "&", true);
         return {
-            method: "post",
+            method: "POST",
             url: `https://api.csswg.org/bikeshed/?url=${ urlencode(this.github_url) }${ query }`
         }
     }

diff --git a/test/models/branch.js b/test/models/branch.js
@@ -142,7 +142,7 @@ suite("Branch model", function() {
             src_file: "index.bs"
         };
         assert.deepEqual(h.getUrl(h.urlOptions()), {
-            method: "post",
+            method: "POST",
             url: BIKESHED_URL + "index.bs"
         });
     });
@@ -155,7 +155,7 @@ suite("Branch model", function() {
         };
 
         assert.deepEqual(h.getUrl(h.urlOptions()), {
-            method: "post",
+            method: "POST",
             url: BIKESHED_URL + "url.bs"
         });
     });
@@ -168,7 +168,7 @@ suite("Branch model", function() {
             params: { "md-status": "REC" }
         };
         assert.deepEqual(h.getUrl(h.urlOptions()), {
-            method: "post",
+            method: "POST",
             url: BIKESHED_URL + "index.bs&md-status=REC"
         });
     });
@@ -184,7 +184,7 @@ suite("Branch model", function() {
             }
         };
         assert.deepEqual(h.getUrl(h.urlOptions()), {
-            method: "post",
+            method: "POST",
             url: BIKESHED_URL +  "index.bs&md-title=FOO%20BAR%20tobie%2Fwebidl%2Finterface-objs%23283-7dfd134"
         });
     });
@@ -199,7 +199,7 @@ suite("Branch model", function() {
             }
         };
         assert.deepEqual(h.getUrl(h.urlOptions()), {
-            method: "post",
+            method: "POST",
             url: BIKESHED_URL + "index.bs&force=1"
         });
     });