Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Add tls support to amqtt #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tls support to amqtt #425

wants to merge 1 commit into from

Conversation

sehraf
Copy link

@sehraf sehraf commented Jul 4, 2019

Enable by setting -D ASYNC_TCP_SSL_ENABLED=1 as build flag.
The addition to /esp_status turned out to be usefull for debugging so i've included it.

Tested on NodeMCU with mosquitto.

To retrieve the fingerprint you can run

openssl s_client -connect <host>:<port> < /dev/null 2>/dev/null | openssl x509 -fingerprint -noout -in /dev/stdin

@toblum
Copy link
Owner

toblum commented Jul 5, 2019

Thank you for your contribution @sehraf,

we'll have a look on it.

Regards
Tobias

Copy link
Collaborator

@debsahu debsahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, have to test it (especially memory management). And users have to compile using instructions at https://github.com/marvinroger/async-mqtt-client/blob/master/docs/4.-Limitations-and-known-issues.md#ssl-limitations These needs to be added to wiki.

@toblum
Copy link
Owner

toblum commented Jul 13, 2019

@debsahu Thanks for taking a look. I remembered you did some investigations on using SSL on the ESP.
I'm currently a bit lost on the state of the code of McL as I was out of the project for some time and there was so much going on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants