Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: rename image/container name from "webgoat" to "webgoat.net" #28

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

pkrukp
Copy link

@pkrukp pkrukp commented Nov 17, 2020

Closes #13

@tobyash86
Copy link
Owner

@pkruk2 have you checked that the new name including dot does not have any side effects?

@pkrukp
Copy link
Author

pkrukp commented Nov 17, 2020

I have checked that I can run it (using linux containers). Also, other images have dots and special characters, for example "mcr.microsoft.com/dotnet/core/sdk:3.1". Further looking at docker/compose#1519 the dot "." is allowed. I haven't found explicit documentation in docker about it.

@tobyash86
Copy link
Owner

Great, thanks!

@tobyash86 tobyash86 merged commit 8e12076 into dev Nov 17, 2020
@tobyash86 tobyash86 deleted the rename-docker branch November 20, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename docker image for WebGoat
2 participants