This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
fix: disable auto build on push #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpapst
approved these changes
Feb 11, 2023
There was a problem hiding this comment.
Which is really weird. I created a 2.0 tag, but no tag and did not expect that this triggers, neither for tags nor for pre-releases.
Anyway: this is hopefully just a short period of overlap and I'll let you know when there is a new minor release.
And I have no idea if GitHub actions likes that there is no trigger now under workflow_dispatch, so this approval is based on the assumption that the action will be ignored and not error out due to the missing child nodes.
|
I'm pretty sure workflow dispatch enables the button on the actions UI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow auto builds the highest numbered version it can find and currently that's the v2 beta build. Rather than re-working the CI, we'll just disable the workflow for now and you can just ping me when you release and I'll do a manual build.
When v2 is released, we'll re-enable it