This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
fix(assets): Ensure apache2/fpm running as PID 1 #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to stop container quickly, we need to run apache2 or fpm as PID 1 * Use CMD "exec form" instead of "shell form" * Use exec "binary" instead of "binary" * Use apache2 instead of apache2ctl * See also https://docs.docker.com/engine/reference/builder/#understand-how-cmd-and-entrypoint-interact
tobybatch
approved these changes
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to stop container quickly, we need to run apache2 or fpm as PID 1