Fix: allow $ to appear in postgres/redshift identifiers (#1512)

tobymao · May 1, 2023 · 6143491 · 6143491
1 parent adc526c
commit 6143491
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/sqlglot/dialects/postgres.py b/sqlglot/dialects/postgres.py
@@ -248,6 +248,8 @@ class Tokenizer(tokens.Tokenizer):
             "$": TokenType.PARAMETER,
         }
 
+        VAR_SINGLE_TOKENS = {"$"}
+
     class Parser(parser.Parser):
         STRICT_CAST = False
 

diff --git a/tests/dialects/test_postgres.py b/tests/dialects/test_postgres.py
@@ -89,6 +89,7 @@ def test_postgres(self):
         self.validate_identity("SELECT ARRAY[1, 2, 3] <@ ARRAY[1, 2]")
         self.validate_identity("SELECT ARRAY[1, 2, 3] && ARRAY[1, 2]")
         self.validate_identity("$x")
+        self.validate_identity("x$")
         self.validate_identity("SELECT ARRAY[1, 2, 3]")
         self.validate_identity("SELECT ARRAY(SELECT 1)")
         self.validate_identity("SELECT ARRAY_LENGTH(ARRAY[1, 2, 3], 1)")

diff --git a/tests/dialects/test_redshift.py b/tests/dialects/test_redshift.py
@@ -7,6 +7,8 @@ class TestRedshift(Validator):
     def test_redshift(self):
         self.validate_identity("SELECT * FROM #x")
         self.validate_identity("SELECT INTERVAL '5 day'")
+        self.validate_identity("foo$")
+        self.validate_identity("$foo")
 
         self.validate_all(
             "SELECT SNAPSHOT",