Fix: bigquery timestamp -> timestamptz

tobymao · Jun 15, 2023 · fd0fc97 · fd0fc97
1 parent 1d65d8a
commit fd0fc97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/sqlglot/dialects/bigquery.py b/sqlglot/dialects/bigquery.py
@@ -153,6 +153,7 @@ class Tokenizer(tokens.Tokenizer):
             "FLOAT64": TokenType.DOUBLE,
             "INT64": TokenType.BIGINT,
             "RECORD": TokenType.STRUCT,
+            "TIMESTAMP": TokenType.TIMESTAMPTZ,
             "NOT DETERMINISTIC": TokenType.VOLATILE,
             "UNKNOWN": TokenType.NULL,
         }
@@ -340,6 +341,7 @@ class Generator(generator.Generator):
             exp.DataType.Type.NVARCHAR: "STRING",
             exp.DataType.Type.SMALLINT: "INT64",
             exp.DataType.Type.TEXT: "STRING",
+            exp.DataType.Type.TIMESTAMP: "DATETIME",
             exp.DataType.Type.TIMESTAMPTZ: "TIMESTAMP",
             exp.DataType.Type.TIMESTAMPLTZ: "TIMESTAMP",
             exp.DataType.Type.TINYINT: "INT64",

diff --git a/tests/dialects/test_bigquery.py b/tests/dialects/test_bigquery.py
@@ -74,6 +74,7 @@ def test_bigquery(self):
             "SELECT * FROM `my-project.my-dataset.my-table`",
             write={"bigquery": "SELECT * FROM `my-project`.`my-dataset`.`my-table`"},
         )
+        self.validate_all("CAST(x AS DATETIME)", read={"": "x::timestamp"})
         self.validate_identity("CAST(x AS TIMESTAMP)")
         self.validate_all("LEAST(x, y)", read={"sqlite": "MIN(x, y)"})
         self.validate_all("CAST(x AS CHAR)", write={"bigquery": "CAST(x AS STRING)"})