Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(snowflake): translate [CHAR|NCHAR] VARYING into VARCHAR #1634

Merged
merged 1 commit into from
May 16, 2023
Merged

Feat(snowflake): translate [CHAR|NCHAR] VARYING into VARCHAR #1634

merged 1 commit into from
May 16, 2023

Conversation

georgesittas
Copy link
Collaborator

Fixes #1632

@tobymao tobymao merged commit 13a731a into main May 16, 2023
@tobymao tobymao deleted the jo/snowflake_char_varying branch May 16, 2023 14:43
@dave-connors-3
Copy link

thanks for the quick fix! I believe snowflake also allows for the fully qualified version of this type too @georgesittas

image

@georgesittas
Copy link
Collaborator Author

georgesittas commented May 16, 2023 •
edited
Loading

The char varying(50) one is already supported, I'll add character varying

@georgesittas
Copy link
Collaborator Author

06d6990

adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@georgesittas @adrianisk
Feat(snowflake): translate [CHAR|NCHAR] VARYING into VARCHAR (tobymao…
87f6c99 
…#1634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CHAR VARYING and NCHAR VARYING not parsed for Snowflake
3 participants
@georgesittas @dave-connors-3 @tobymao