Chore!: improve python type hints #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
May 25, 2023
tobymao
reviewed
May 25, 2023
tobymao
reviewed
May 25, 2023
tobymao
approved these changes
May 25, 2023
georgesittas
force-pushed
the
jo/improve_type_hints
branch
from
4162d41
to
7fdc9f2
Compare
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
* Chore!: improve python type hints * More improvements * Factor out E and T types into sqlglot._typing * Fixup * Fixup * Fixup * Fixup * Fixup * Fixup * Fixup * Fixup * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a sweep in the codebase to clean up the type hints. All files under
sqlglot/dialectsshould be now fully typed.This is still a WIP, gonna continue iterating on it tomorrow to do any remaining fixes.