Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(schema): allow passing kwargs in ensure_schema #1706

Merged
merged 1 commit into from
May 31, 2023
Merged

Feat(schema): allow passing kwargs in ensure_schema #1706

merged 1 commit into from
May 31, 2023

Conversation

georgesittas
Copy link
Collaborator

@georgesittas georgesittas commented May 31, 2023 •
edited
Loading

Minor addition: now we can specify other args besides dialect in ensure_schema. This can be useful if e.g. we want to instantiate a MappingSchema with normalize=False or visible={...}.

@tobymao tobymao merged commit 24d44ad into main May 31, 2023
@tobymao tobymao deleted the jo/improve_ensure_schema branch May 31, 2023 15:35
adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@georgesittas @adrianisk
Feat(schema): allow passing kwargs in ensure_schema (tobymao#1706)
58bafb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgesittas @tobymao